Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow down supported browsers in Browserslist config according to the docs #476

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Narrow down supported browsers in Browserslist config according to the docs #476

merged 1 commit into from
Sep 11, 2023

Conversation

adamkudrna
Copy link
Member

@adamkudrna adamkudrna commented Aug 4, 2023 •
edited
Loading 

npx browserslist

and_chr 116
and_ff 116
chrome 116
chrome 115
edge 116
edge 115
firefox 117
firefox 116
firefox 115
firefox 102
ios_saf 16.5
ios_saf 16.4
ios_saf 16.3
ios_saf 16.2
ios_saf 16.1
ios_saf 16.0
safari 16.6
safari 16.5
safari 16.4
safari 16.3
safari 16.2
safari 16.1
safari 16.0

@adamkudrna adamkudrna requested a review from a team August 4, 2023 16:01
@adamkudrna adamkudrna self-assigned this Aug 4, 2023
@adamkudrna adamkudrna requested review from a team and removed request for a team August 7, 2023 13:26
@bedrich-schindler
Copy link
Contributor

I am just curious. What is behind this change? Why don't we support two latest browsers as before? Be aware, that we must/should support the latest major versions in some of our clients ...

Base automatically changed from bc/require-node-18 to master August 9, 2023 10:58
@adamkudrna adamkudrna force-pushed the maintenance/supported-browsers branch from 184aa8c to 77e0c53 Compare August 11, 2023 10:43
@adamkudrna
Copy link
Member Author

I am just curious. What is behind this change? Why don't we support two latest browsers as before? Be aware, that we must/should support the latest major versions in some of our clients ...

@bedrich-schindler I did two things:

  1. Changed the vague defaults config to an explicit white-list (allow-list 👀 ) of browser versions.
  2. Desktop browsers still support last 2 major versions. I only limited mobile browsers to the most recent major version. I believe it is based on our discussion about pre-15.4 versions of mobile Safari which are still "2 major versions back", but much less capable. However, I can change the config to be more open and include at least the last 2 versions of other mobile browsers.

What do you think?

@adamkudrna adamkudrna force-pushed the maintenance/supported-browsers branch from 77e0c53 to 99827d1 Compare August 11, 2023 10:57
mbohal
mbohal approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@mbohal mbohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add Firefox ESR support.

@adamkudrna
Copy link
Member Author

I would add Firefox ESR support.

That effectively means supporting up to one-year-old version of Firefox (version 102 as of today). I think we may be open to fixing bugs reported in ESR, but I doubt we can actively test in it…

Anyway, I'm adding ESR to the list.

@adamkudrna adamkudrna force-pushed the maintenance/supported-browsers branch from 99827d1 to 9263d7a Compare September 11, 2023 15:01
@adamkudrna adamkudrna merged commit fa2f5e5 into master Sep 11, 2023
@adamkudrna adamkudrna deleted the maintenance/supported-browsers branch September 11, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedrich-schindler bedrich-schindler bedrich-schindler approved these changes

@mbohal mbohal mbohal approved these changes

Assignees

@adamkudrna adamkudrna

Labels
maintenance
Projects
The Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkudrna @bedrich-schindler @mbohal